Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #543

Merged
merged 14 commits into from
Feb 1, 2020
Merged

Refactor #543

merged 14 commits into from
Feb 1, 2020

Conversation

liyasthomas
Copy link
Member

@liyasthomas liyasthomas commented Jan 31, 2020 •
edited by jamesgeorge007
Loading

  • Use template literals.
  • Prefer Object destructuring assignment approach.
  • let to const.
  • Other minor tweaks.

@ghost
Copy link

ghost commented Jan 31, 2020 •
edited by ghost
Loading

DeepCode's analysis on #0f55b8 found:

  • ❌ 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@liyasthomas liyasthomas self-assigned this Jan 31, 2020
@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7c63b930-43c5-11ea-9235-e14405c2c5dd

jamesgeorge007
jamesgeorge007 requested changes Jan 31, 2020
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of comments.

components/ace-editor.vue Show resolved Hide resolved
pages/index.vue Show resolved Hide resolved
pages/index.vue Outdated Show resolved Hide resolved
pages/index.vue Outdated Show resolved Hide resolved
@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: bed2c260-442a-11ea-9f07-3f0e27299721

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: cb425960-4435-11ea-9f07-3f0e27299721

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f144b9f0-4435-11ea-9f07-3f0e27299721

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 1574f290-4436-11ea-9f07-3f0e27299721

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 74b0b810-4437-11ea-9f07-3f0e27299721

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 54f8aaf0-4504-11ea-a2f3-4fd442160d61

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7d8d8d80-4515-11ea-8ac1-cf2d15c11453

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 187131d0-4516-11ea-8ac1-cf2d15c11453

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: fffd0dc0-4517-11ea-8ac1-cf2d15c11453

liyasthomas
liyasthomas commented Feb 1, 2020
View reviewed changes
Copy link
Member Author

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 8de7ece0-4518-11ea-8ac1-cf2d15c11453

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: aaeecd90-4518-11ea-8ac1-cf2d15c11453

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b385f0e0-4519-11ea-8ac1-cf2d15c11453

@jamesgeorge007 jamesgeorge007 merged commit 4c62baa into master Feb 1, 2020
@jamesgeorge007 jamesgeorge007 deleted the refactor branch February 1, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

Assignees

@liyasthomas liyasthomas

@jamesgeorge007 jamesgeorge007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liyasthomas @TravisBuddy @jamesgeorge007