Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update e2e tests #546

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

yubathom
Copy link
Contributor

@yubathom yubathom commented Feb 2, 2020

Some updates to e2e tests:

Some tests were failing because the vm of the ci was loading the assets (and the page was not ready to run the first test). This is a screenshot from a test that runned at travis:

cypress-screenshot

@ghost
Copy link

ghost commented Feb 2, 2020

DeepCode's analysis on #85c5f1 found:

  • 0 critical issues. ⚠️ 0 warnings and 2 minor issues. ✔️ 2 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@TravisBuddy
Copy link

Hey @yubathom,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 9da13dc0-457d-11ea-8ac1-cf2d15c11453

@liyasthomas
Copy link
Member

@yubathom thank you for this PR.

@liyasthomas liyasthomas merged commit 67e98ef into hoppscotch:master Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants