Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved common headers to a separate file #566

Merged
merged 7 commits into from
Feb 11, 2020

Conversation

AndrewBastin
Copy link
Member

Just a small refactor to move the common headers to a separate file.

@AndrewBastin AndrewBastin added the refactor Code refactoring label Feb 10, 2020
@AndrewBastin AndrewBastin self-assigned this Feb 10, 2020
@ghost
Copy link

ghost commented Feb 10, 2020

DeepCode's analysis on #af18b9 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@TravisBuddy
Copy link

Hey @AndrewBastin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 39d58c20-4c5c-11ea-a602-3b1447b731d3

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 5fdc1b50-4c70-11ea-a602-3b1447b731d3

liyasthomas
liyasthomas previously approved these changes Feb 11, 2020
@TravisBuddy
Copy link

Hey @AndrewBastin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a7dee0c0-4cb3-11ea-8d64-99834d90edda

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a4047040-4cb4-11ea-8d64-99834d90edda

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 32e40fa0-4cb5-11ea-8d64-99834d90edda

@TravisBuddy
Copy link

Hey @AndrewBastin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f0689d30-4cb9-11ea-8d64-99834d90edda

@TravisBuddy
Copy link

Hey @AndrewBastin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 63fe58b0-4cbb-11ea-8d64-99834d90edda

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 4b2255a0-4cbe-11ea-8d64-99834d90edda

@liyasthomas liyasthomas merged commit bd3e1b7 into hoppscotch:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants