Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop the toast which doesn't show up #572

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Conversation

jamesgeorge007
Copy link
Member

Follow up of #571

The share button seems to show up only if Web Share API is supported in the user's browser.

@ghost
Copy link

ghost commented Feb 15, 2020

DeepCode's analysis on #c2cd9f found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@jamesgeorge007 jamesgeorge007 self-assigned this Feb 15, 2020
@jamesgeorge007 jamesgeorge007 added this to the v2.0 milestone Feb 15, 2020
@jamesgeorge007 jamesgeorge007 added the core Changes regarding core concepts label Feb 15, 2020
@TravisBuddy
Copy link

Hey @jamesgeorge007,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: df199e00-4fbe-11ea-97b4-2505cffd77c3

@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d135fc40-4fc1-11ea-97b4-2505cffd77c3

@jamesgeorge007 jamesgeorge007 merged commit 112c140 into master Feb 15, 2020
@jamesgeorge007 jamesgeorge007 deleted the hotfix/share branch February 15, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes regarding core concepts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants