Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Chrome and Firefox extensions #573

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Unify Chrome and Firefox extensions #573

merged 2 commits into from
Feb 20, 2020

Conversation

levrik
Copy link
Contributor

@levrik levrik commented Feb 15, 2020 •
edited
Loading

See hoppscotch/hoppscotch-extension#2 for more details.

I would propose to merge and release this change here a few days before releasing a new version of the extensions. So the new code inside Postwoman is loaded on most machines and nothing breaks.

Please wait until the PR at postwoman-chrome is approved before merging anything. Maybe more changes are needed here based on feedback.

@levrik levrik mentioned this pull request Feb 15, 2020
Merged
@ghost
Copy link

ghost commented Feb 15, 2020 •
edited by ghost
Loading

Congratulations 🍻. DeepCode analyzed your code in 0.104 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@TravisBuddy
Copy link

Hey @levrik,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 1a4fa160-5030-11ea-99fd-116f3aa85035

@TravisBuddy
Copy link

Hey @levrik,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 679bba20-5031-11ea-99fd-116f3aa85035

@levrik levrik changed the title Unify Firefox and Chrome extensions Unify Chrome and Firefox extensions Feb 16, 2020
@levrik levrik marked this pull request as ready for review February 16, 2020 14:48
@TravisBuddy
Copy link

Hey @levrik,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 89c549e0-50cc-11ea-8780-e55e8d131b8a

@TravisBuddy
Copy link

Hey @levrik,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 507aeda0-50ce-11ea-8780-e55e8d131b8a

@AndrewBastin
Copy link
Member

@levrik

Thanks for the contribution!

I will review the PR in the coming days as I am kinda taking a break right now for personal reasons.
Hope to get back to you on this by Tuesday.

AndrewBastin
AndrewBastin reviewed Feb 20, 2020
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@AndrewBastin
Copy link
Member

@liyasthomas you can merge when you ready 👍

@TravisBuddy
Copy link

Hey @levrik,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a6056da0-5389-11ea-b947-7d804ffb522c

@liyasthomas liyasthomas merged commit a98636e into hoppscotch:master Feb 20, 2020
@levrik levrik deleted the unify-extensions branch February 20, 2020 17:26
@levrik levrik mentioned this pull request Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

@AndrewBastin AndrewBastin AndrewBastin approved these changes

Assignees

@AndrewBastin AndrewBastin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@levrik @TravisBuddy @AndrewBastin @liyasthomas