Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST request body editor reacts to the content type #594

Merged

Conversation

AndrewBastin
Copy link
Member

The Raw Request Body editor for POST requests is set to JSON mode and only provided the syntax highlighting mode for JSON. This PR intends to add the ability to for the user to update the syntax highlighting by updating the Content-Type.

So, for example, if the POST Content-Type is set to application/xml, the raw request editor updates the language mode to XML mode and if the request mode is set to application/json, it updates the mode to JSON Syntax Highlighting mode.

@ghost
Copy link

ghost commented Feb 24, 2020

DeepCode's analysis on #fa339a found:

  • 0 critical issues. ⚠️ 0 warnings and 1 minor issue. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@AndrewBastin AndrewBastin self-assigned this Feb 24, 2020
@AndrewBastin AndrewBastin added the feature New feature or request label Feb 24, 2020
@TravisBuddy
Copy link

Hey @AndrewBastin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2a3c0eb0-56c0-11ea-8ad8-19cca21d7143

@AndrewBastin
Copy link
Member Author

@liyasthomas you should look into why the CI giving hick-ups all the time.... 🙄

@liyasthomas
Copy link
Member

liyasthomas commented Feb 24, 2020

it's an issue with CI itself. 😞

it'll always pass on 2nd run. but don't know why this is happening. I'll issue a compliant.

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 55a53600-56c8-11ea-8ad8-19cca21d7143

@AndrewBastin AndrewBastin merged commit 5ec9944 into hoppscotch:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants