Improve page load/unload experience (remove FOUCs) #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode's analysis on #6962d2 found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
liyasthomas
reviewed
Feb 25, 2020
| font-display: swap; | ||
| // Do not use font-display: swap for the icon font - it looks really bad when the page | ||
| // loads. | ||
| font-display: block; |
|
Hey @NBTX, TravisBuddy Request Identifier: 6ad64750-5766-11ea-821d-47621684b1e8 |
|
Hey @NBTX, TravisBuddy Request Identifier: 8f1d8a60-5766-11ea-821d-47621684b1e8 |
|
Hey @NBTX, TravisBuddy Request Identifier: 0efc65f0-576f-11ea-b14f-b186f6b55800 |
liyasthomas
approved these changes
Feb 25, 2020
|
Awesome @NBTX :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to the UI in terms of page loading/unloading.