Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added shortcut to quickly run the GraphQL query #620

Merged
merged 7 commits into from
Feb 28, 2020
Merged

Added shortcut to quickly run the GraphQL query #620

merged 7 commits into from
Feb 28, 2020

Conversation

AndrewBastin
Copy link
Member

This PR introduces a new shortcut to the GraphQL Query Editor which allows the user press Ctrl+Enter (Cmd+Enter on Mac) to run the query while editing in the query editor.

@AndrewBastin AndrewBastin self-assigned this Feb 28, 2020
@ghost
Copy link

ghost commented Feb 28, 2020 •
edited by ghost
Loading

Congratulations 🍻. DeepCode analyzed your code in 0.29 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@AndrewBastin AndrewBastin added the feature New feature or request label Feb 28, 2020
@dihmeetree dihmeetree self-requested a review February 28, 2020 03:04
dihmeetree
dihmeetree approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@dihmeetree dihmeetree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on Windows! Haven't tested on a Mac; however I am getting a Macbook on Saturday, and can test then. Up to you, what you want to do @AndrewBastin

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b981f010-59d8-11ea-af10-7fd2d08fe4df

@AndrewBastin
Copy link
Member Author

@dmitryyankowski let @liyasthomas also review and merge the code.

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 54978ef0-59db-11ea-af10-7fd2d08fe4df

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 69c52b60-5a59-11ea-af10-7fd2d08fe4df

@dihmeetree dihmeetree merged commit 8df5a5e into hoppscotch:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dihmeetree dihmeetree dihmeetree approved these changes

@liyasthomas liyasthomas liyasthomas approved these changes

Assignees

@AndrewBastin AndrewBastin

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewBastin @TravisBuddy @liyasthomas @dihmeetree