Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor GraphQL page improvements #631

Merged
merged 5 commits into from
Feb 29, 2020
Merged

Minor GraphQL page improvements #631

merged 5 commits into from
Feb 29, 2020

Conversation

dihmeetree
Copy link
Contributor

@dihmeetree dihmeetree commented Feb 29, 2020

  • Schema will show (waiting to receive schema) until the schema is actually requested. (There's no point to show the editor box if there's no schema)
    image

  • Added default values for the Query and Variables editors (Most people coming to this page might not even know what GraphQL is. So it's best to give them an example of a query and the correct variables to pass. They can go right to the GraphQL page and click the runQuery button)
    image

  • Response will show (waiting to receive response) (Similar to reasoning above)
    image

  • Decreased the minLines for variables to 10, minLines for variables to 5, and minLines for response to 10.

@ghost
Copy link

ghost commented Feb 29, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.364 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@TravisBuddy
Copy link

Hey @dmitryyankowski,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 59246660-5b15-11ea-b66e-89572c858fbd

@TravisBuddy
Copy link

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d7034ce0-5b15-11ea-b66e-89572c858fbd

@TravisBuddy
Copy link

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 637d9a20-5b18-11ea-b66e-89572c858fbd

@TravisBuddy
Copy link

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 048680f0-5b26-11ea-b66e-89572c858fbd

@liyasthomas liyasthomas merged commit fc615a0 into hoppscotch:master Feb 29, 2020
@dihmeetree dihmeetree deleted the gql/editor-updates branch March 1, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants