Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add socket io support #640

Merged
merged 3 commits into from
Mar 4, 2020

Conversation

moonrailgun
Copy link
Contributor

@moonrailgun moonrailgun commented Mar 4, 2020

Add Socket.IO support, resolves #611

Now is a simple implement , more feature will be append soon.

Pick up some function to separate file, please check it.

By the way, i have not found a public socketio server as a default value, is any good idea to improve it?

and modify some websocket and sse code to pick up common function and component
@ghost
Copy link

ghost commented Mar 4, 2020

DeepCode's analysis on #6a9672 found:

  • 0 critical issues. ⚠️ 0 warnings and 2 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@TravisBuddy
Copy link

Hey @moonrailgun,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 999f8110-5de6-11ea-8706-0d65ca3fb05e

@liyasthomas
Copy link
Member

liyasthomas commented Mar 4, 2020

@moonrailgun thanks for the quick PR 🎉

https://amritb.github.io/socketio-client-tool/ fyi this open source tool is feature rich! We can make use of this for future features.

We should allow http/https protocols other than ws/wss for Socket.io endpoints. For ex: https://socket-io-chat.now.sh/ is an socker.io endpoint which will be rejected by current URL validation. Without the https protocol, it works fine though.

By the way, I couldn't find a public socket.io endpoint for default value. Anyways, we'll add that later.

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@TravisBuddy
Copy link

Hey @moonrailgun,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c8f12800-5e00-11ea-8706-0d65ca3fb05e

@liyasthomas liyasthomas self-requested a review March 4, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SocketIO connections on Realtime page
3 participants