-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add socket io support #640
Conversation
and modify some websocket and sse code to pick up common function and component
DeepCode's analysis on #6a9672 found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
Hey @moonrailgun, TravisBuddy Request Identifier: 999f8110-5de6-11ea-8706-0d65ca3fb05e |
@moonrailgun thanks for the quick PR 🎉 https://amritb.github.io/socketio-client-tool/ fyi this open source tool is feature rich! We can make use of this for future features. We should allow By the way, I couldn't find a public socket.io endpoint for default value. Anyways, we'll add that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
Hey @moonrailgun, TravisBuddy Request Identifier: c8f12800-5e00-11ea-8706-0d65ca3fb05e |
Add Socket.IO support, resolves #611
Now is a simple implement , more feature will be append soon.
Pick up some function to separate file, please check it.
By the way, i have not found a public socketio server as a default value, is any good idea to improve it?