Fix setting default raw params #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with master
|
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
|
Hey @leomp12, TravisBuddy Request Identifier: 0ae0a6b0-6887-11ea-9beb-cb7d09b98ed8 |
liyasthomas
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR comes with a minor bug here https://github.com/liyasthomas/postwoman/pull/678/files#diff-b19fa22add3de9cd0b98b05366479d92R1442 😞
It's always true, so every time content type is changed to
application/jsonbody will be reset.I'm fixing it here and also ensuring body is being reset to defaults only if it was not manually changed (empty or equals to default body for old content type).