Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to navigate through message history #828

Merged
merged 5 commits into from
Apr 30, 2020

Conversation

jinyus
Copy link

@jinyus jinyus commented Apr 30, 2020

Navigate through your message history with the up and down arrows when the message input box is in focus.

@liyasthomas
Copy link
Member

@jinyus can you make a screencast of what this PR does? I can't produce the intended behavior on deploy preview: https://deploy-preview-828--postwoman.netlify.app/realtime

Please paste a GIF/video of how to reproduce the intended behaviour on deploy preview.

@jinyus
Copy link
Author

jinyus commented Apr 30, 2020

Here is the demo
When you click on the message box, you can cycle through your recent messages using the up and down arrows

@liyasthomas
Copy link
Member

liyasthomas commented Apr 30, 2020

Oops, that link is broken: https://streamable.com/flrt82

Got it 👍

@TravisBuddy
Copy link

Hey @jinyus,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7e9c3580-8abd-11ea-b0c3-9bf8056a98a6

@TravisBuddy
Copy link

Hey @jinyus,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a091ffc0-8ac3-11ea-b0c3-9bf8056a98a6

@liyasthomas liyasthomas merged commit 2adead9 into hoppscotch:master Apr 30, 2020
@jinyus jinyus deleted the wsockdev branch April 30, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants