-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL Path Parameters #834 #840
URL Path Parameters #834 #840
Conversation
Hey @sboulema, TravisBuddy Request Identifier: 9435b390-8d32-11ea-bfcd-ab7027f5d872 |
Hey @sboulema, TravisBuddy Request Identifier: ab681df0-8d32-11ea-bfcd-ab7027f5d872 |
@sboulema I can't reproduce this PR's intended behaviour on the deploy preview: https://deploy-preview-840--postwoman.netlify.app/ Environment variables added from parameters list with |
Wow sorry it only worked in a couple of scenarios. Updated the PR works much more reliably now! |
Hey @sboulema, TravisBuddy Request Identifier: 1e5d2420-8eca-11ea-80eb-6b769f7cd14d |
Hey @sboulema, TravisBuddy Request Identifier: dda2b840-8ef2-11ea-80eb-6b769f7cd14d |
Looks like this was merged but I don't see it in the UI. Has it moved or changed? Or is setting runtime environment variables via pre-request scripts still the preferred way of implementing URL path parameters? |
Adds a type dropdown to the current parameter list. Based on the type, the parameter either gets included as a query parameter or gets added as an environment variable so it can be used in the current url path template replacement.
Parameters without a type are treated as query parameters so the implementation is backwards-compatible.
This way the parameter gets saved with the request and does not have to be saved with the environment.