Cancellable Requests #915
Merged
Cancellable Requests #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AndrewBastin, TravisBuddy Request Identifier: c984c4c0-a2c5-11ea-a8e9-e7e13745aead |
|
@AndrewBastin no need of red bg color. "Cancel" isn't a errored state - moreover, there's a red theme in our themes. feel free to merge the PR. |
liyasthomas
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add the ability to cancel running requests.
@liyasthomas what do you think about the cancel button ? should it be red or something ?
The browser extensions don't currently support cancellable requests, the cancel attempts will just be ignored in case of extensions for now, the support implementation will be rolled with extension version v0.10 which is a bit delayed as I am waiting for approval for the extension to the Microsoft Edge add-on store.
This PR fixes #909