Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: environment and collection sync issue with firebase #926

Conversation

myussufz
Copy link

@myussufz myussufz commented Jun 7, 2020

Fixes #900

@TravisBuddy
Copy link

Hey @myussufz,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c1696f60-a8de-11ea-b23f-e753f45396de

@liyasthomas
Copy link
Member

@myussufz thanks for the quick PR, I'll merge it ASAP after running some tests.

@TravisBuddy
Copy link

Hey @myussufz,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 34e40f80-a8e5-11ea-b23f-e753f45396de

@myussufz
Copy link
Author

myussufz commented Jun 7, 2020

@liyasthomas I push more changes to fix the sync with firebase, so it able to sync with firebase more often, you may try to check whether it works as expected or not.

@TravisBuddy
Copy link

Hey @myussufz,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 8a4fdc30-a8e8-11ea-b23f-e753f45396de

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@liyasthomas liyasthomas self-assigned this Jun 7, 2020
@liyasthomas liyasthomas added the bug fix This fixes a bug label Jun 7, 2020
@liyasthomas liyasthomas added this to the v2.0 milestone Jun 7, 2020
@liyasthomas liyasthomas merged commit 7387acd into hoppscotch:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collections & Environments not synced
3 participants