Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpiled ES5 code to ES6/ES7 #934

Merged
merged 5 commits into from
Jun 12, 2020
Merged

Transpiled ES5 code to ES6/ES7 #934

merged 5 commits into from
Jun 12, 2020

Conversation

liyasthomas
Copy link
Member

@liyasthomas liyasthomas commented Jun 11, 2020

This PR intends to minify code base, increase efficiency and ultimately make it easier to manage it.

  • Transpiled ES5 code to ES6/ES7
  • Test
  • Review

@AndrewBastin @jamesgeorge007 kindly help me to test and check any functionalities are broken by the ES5 to ES6/ES7 transpile - take your time to review.

Deploy preview: https://deploy-preview-934--postwoman.netlify.app/

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e104cb70-abf0-11ea-a7dd-93c9ffbfb007

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 02b3b060-abf1-11ea-a7dd-93c9ffbfb007

Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted this at a quick glance.

components/collections/importExportCollections.vue Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jun 11, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.654 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@liyasthomas
Copy link
Member Author

Retry DeepCode

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: fc916400-abf7-11ea-a7dd-93c9ffbfb007

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7a1ce6d0-ac5a-11ea-a7dd-93c9ffbfb007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants