From c9873d4844b901601c3619d388f852a7d53edf4d Mon Sep 17 00:00:00 2001 From: Yelyzaveta Veis Date: Sun, 5 Nov 2023 22:33:15 +0200 Subject: [PATCH 1/2] Revert "development: + needs parameter to create release step" This reverts commit 1f19200dfadd2e0683a817af4b84424ce0289ae7. --- .github/workflows/create-release.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml index 168ec29..e426261 100644 --- a/.github/workflows/create-release.yml +++ b/.github/workflows/create-release.yml @@ -46,7 +46,7 @@ jobs: - name: Determine incremented release version id: determine_incremented_release_version - if: ${{ !github.event.inputs.version }} + if: ${{ !github.event.inputs.version && !steps.extract_version_from_pr_title.outputs.version }} uses: reecetech/version-increment@2023.9.3 with: scheme: semver @@ -54,9 +54,6 @@ jobs: - name: Create release uses: softprops/action-gh-release@v1 - needs: - - extract_version_from_pr_title - - determine_incremented_release_version with: token: ${{ secrets.GITHUB_TOKEN }} tag_name: ${{ github.event.inputs.version || From f4602289c94eb514c25a3335f7e75b3b480e229b Mon Sep 17 00:00:00 2001 From: Yelyzaveta Veis Date: Sun, 5 Nov 2023 22:44:10 +0200 Subject: [PATCH 2/2] development: * steps ids --- .github/workflows/create-release.yml | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml index e426261..efc6163 100644 --- a/.github/workflows/create-release.yml +++ b/.github/workflows/create-release.yml @@ -32,7 +32,7 @@ jobs: uses: actions/checkout@v4 - name: Extract release version from Pull Request title - id: extract_version_from_pr_title + id: extract-version-from-pr-title if: ${{ !github.event.inputs.version && github.event.pull_request.merged }} run: | pr_title="${{ github.event.pull_request.title }}" @@ -40,13 +40,10 @@ jobs: version="${BASH_REMATCH}" echo "version=$version" >> $GITHUB_OUTPUT fi - echo ${{ steps.extract_version_from_pr_title.outputs.version }} - echo "::set-output name=version::$version" - echo ${{ steps.extract_version_from_pr_title.outputs.version }} - name: Determine incremented release version - id: determine_incremented_release_version - if: ${{ !github.event.inputs.version && !steps.extract_version_from_pr_title.outputs.version }} + id: determine-incremented-release-version + if: ${{ !github.event.inputs.version && !steps.extract-version-from-pr-title.outputs.version }} uses: reecetech/version-increment@2023.9.3 with: scheme: semver @@ -57,6 +54,6 @@ jobs: with: token: ${{ secrets.GITHUB_TOKEN }} tag_name: ${{ github.event.inputs.version || - steps.extract_version_from_pr_title.outputs.version || - steps.determine_incremented_release_version.outputs.version }} + steps.extract-version-from-pr-title.outputs.version || + steps.determine-incremented-release-version.outputs.version }} generate_release_notes: true