New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there something missing in dphs derivation? #4

Open

pg2455 opened this issue Jul 25, 2018 · 0 comments

pg2455 commented Jul 25, 2018 •

edited

Loading

Hi,

Current formulation of dphs is

dphs = np.dot(dc, self.c)[:self.ys] + np.dot(do, self.o)[:self.ys] + np.dot(di, self.i)[:self.ys] + np.dot(df, self.f)[:self.ys]

I think it should be:

dphs = np.dot(dc * self.dtangent(c), self.c)[:self.ys] + np.dot(do * self.dtangent(o), self.o)[:self.ys] + \
                 np.dot(di * self.dtangent(i), self.i)[:self.ys] + np.dot(df * self.dtangent(f), self.f)[:self.ys]

dtangent is missing from the derivation. Is that correct?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment