Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make major version 6.0 compatible with PHP 8.1 #308

Closed
llaville opened this issue Dec 9, 2021 · 1 comment
Closed

Make major version 6.0 compatible with PHP 8.1 #308

llaville opened this issue Dec 9, 2021 · 1 comment
Assignees
Labels

Comments

@llaville
Copy link
Owner

llaville commented Dec 9, 2021

CI Unit tests report https://github.com/llaville/php-compatinfo/runs/4472349033?check_suite_focus=true

OK (221 tests, 615 assertions)

Remaining self deprecation notices (3)

  1x: Return type of Bartlett\CompatInfo\Application\Collection\SniffCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
    1x in ParameterTest::functionProvider from Bartlett\CompatInfo\Tests\Reference

  1x: Return type of Bartlett\CompatInfo\Application\Sniffs\KeywordBag::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
    1x in ParameterTest::functionProvider from Bartlett\CompatInfo\Tests\Reference

  1x: Return type of Bartlett\CompatInfo\Application\Sniffs\KeywordBag::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
    1x in ParameterTest::functionProvider from Bartlett\CompatInfo\Tests\Reference

@llaville llaville added the bug label Dec 9, 2021
@llaville llaville self-assigned this Dec 9, 2021
@llaville
Copy link
Owner Author

Fixed with commit c049bfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant