{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":598276727,"defaultBranch":"master","name":"controller-runtime","ownerLogin":"lleshchi","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-02-06T19:17:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/44850593?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1691682226.0","currentOid":""},"activityList":{"items":[{"before":"6eea962e161a5258d826a1f912c461dc9bf537d6","after":"f965032c3da4abe3a0ce4cec485f112713ad911a","ref":"refs/heads/issue_2429","pushedAt":"2023-08-10T15:54:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Add missing return statement in the webhook admissions func\n\nAs the function is currently written without a return, for an\nunstructured object which is successfully unmashalled, it will fall\nthrough to the subsequent lines and fail to decode properly.\n\nAdd return statement to successful unstructured decode.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Add missing return statement in the webhook admissions func"}},{"before":"ba7c3e0ee2168beeaffedb563a00021af04d07cc","after":"f965032c3da4abe3a0ce4cec485f112713ad911a","ref":"refs/heads/issue_2429_draft","pushedAt":"2023-08-10T15:45:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Add missing return statement in the webhook admissions func\n\nAs the function is currently written without a return, for an\nunstructured object which is successfully unmashalled, it will fall\nthrough to the subsequent lines and fail to decode properly.\n\nAdd return statement to successful unstructured decode.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Add missing return statement in the webhook admissions func"}},{"before":null,"after":"ba7c3e0ee2168beeaffedb563a00021af04d07cc","ref":"refs/heads/issue_2429_draft","pushedAt":"2023-08-10T15:43:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Add missing return statement in the webhook admissions func\n\nAs the function is currently written without a return, for an\nunstructured object which is successfully unmashalled, it will fall\nthrough to the subsequent lines and fail to decode properly.\n\nAdd return statement to successful unstructured decode.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Add missing return statement in the webhook admissions func"}},{"before":null,"after":"6eea962e161a5258d826a1f912c461dc9bf537d6","ref":"refs/heads/issue_2429","pushedAt":"2023-08-03T16:06:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Add missing return statement in the webhook admissions func\n\nAs the function is currently written without a return, for an\nunstructured object which is successfully unmashalled, it will fall\nthrough to the subsequent lines and fail to decode properly.\n\nAdd return statement to successful unstructured decode.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Add missing return statement in the webhook admissions func"}},{"before":"c9d95997706a632627ae45190d77cd3ffb0185f9","after":"7a66d580c0c53504f5b509b45e9300cc18a1cc30","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-17T15:21:37.900Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Update fake client deletionTimestamp behavior\n\nThe current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in garbage\ncollection, causing inaccurate or ambiguous behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodifying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Update fake client deletionTimestamp behavior"}},{"before":"b7d4a85dc57c77a1f6847a8997f1265d04fe660f","after":"c9d95997706a632627ae45190d77cd3ffb0185f9","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-17T15:03:08.706Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Update fake client deletionTimestamp behavior\n\nThe current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in garbage\ncollection, causing inaccurate or ambiguous behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodifying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Update fake client deletionTimestamp behavior"}},{"before":"c28b0173c5ae819f1169e3126c57763b1777ae04","after":"b7d4a85dc57c77a1f6847a8997f1265d04fe660f","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-15T15:15:35.696Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Update fake client deletionTimestamp behavior\n\nThe current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in garbage\ncollection, causing inaccurate or ambiguous behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodifying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Update fake client deletionTimestamp behavior"}},{"before":"eeea5bbc7f109140253f91a83d8fe20e9a829e00","after":"c28b0173c5ae819f1169e3126c57763b1777ae04","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-14T01:53:04.843Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Update fake client deletionTimestamp behavior\n\nThe current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in garbage\ncollection, causing inaccurate or ambiguous behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodifying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Update fake client deletionTimestamp behavior"}},{"before":"8522ea3a517f568a705c4b17e007e86e97061403","after":"eeea5bbc7f109140253f91a83d8fe20e9a829e00","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-10T16:50:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Update fake client deletionTimestamp behavior\n\nThe current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in garbage\ncollection, causing inaccurate or ambiguous behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodifying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Update fake client deletionTimestamp behavior"}},{"before":"d83c8011c3fc9a8e39e432d96154f099445458bc","after":"8522ea3a517f568a705c4b17e007e86e97061403","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-10T16:10:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Update fake client deletionTimestamp behavior\n\nThe current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in garbage\ncollection, causing inaccurate or ambiguous behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodifying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Update fake client deletionTimestamp behavior"}},{"before":"96dead55f844471f8e7b29d17f949a952267e094","after":"d83c8011c3fc9a8e39e432d96154f099445458bc","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-10T14:20:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Update fake client deletionTimestamp behavior\n\nThe current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in garbage\ncollection, causing inaccurate or ambiguous behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodifying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Update fake client deletionTimestamp behavior"}},{"before":"fe437aa140dd3795c540c18f8419a3995a8ca5f0","after":"96dead55f844471f8e7b29d17f949a952267e094","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-10T14:19:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Update fake client deletionTimestamp behavior\n\nThe current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in garbage\ncollection, causing inaccurate or ambigious behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodifying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Update fake client deletionTimestamp behavior"}},{"before":"8eefa56de62115eaa0714c1b0ce76dafc4071d92","after":"fe437aa140dd3795c540c18f8419a3995a8ca5f0","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-10T14:13:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Update fake client deletionTimestamp behavior\n\nThe current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in it's garbage\ncollection, causing inaccurate or ambigious behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodififying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Update fake client deletionTimestamp behavior"}},{"before":"60876096bed3ce19dd1b93510181cb286aca7b34","after":"8eefa56de62115eaa0714c1b0ce76dafc4071d92","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-10T14:12:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"The current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in it's garbage\ncollection, causing inaccurate or ambigious behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodififying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"The current fake client methods diverge from the behavior of real k8s."}},{"before":"4f80ba3f373178e630219bc8a441b8a91cbbe594","after":"60876096bed3ce19dd1b93510181cb286aca7b34","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-09T19:18:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"The current fake client methods diverge from the behavior of real k8s.\nThis results in scenarios where an object can be created or modified to\nhave a deletionTimestamp and no finalizers, with a delay in it's garbage\ncollection, causing inaccurate or ambigious behavior in  test cases that\nuse the fake client.\n\nBring fake client behavior closer in line with real k8s behavior by\nmodififying the following:\n- Update() and Patch() will reject changes that set a previously-unset deletionTimestamp\n- Create() will ignore a deletionTimestamp on an object\n- Build() will error if initialized with an object that has a deletionTimestamp but no finalizers;\nbut will accept a deletionTimestamp if it has finalizers.\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"The current fake client methods diverge from the behavior of real k8s."}},{"before":"5bce17d3d7e416d917a84f60013b91a70d6f42a2","after":"4f80ba3f373178e630219bc8a441b8a91cbbe594","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-09T18:20:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Draft\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Draft"}},{"before":"4d42bce4e4d282cbe11d7526e45830bee04bfc58","after":"5bce17d3d7e416d917a84f60013b91a70d6f42a2","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-08T15:41:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Draft\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Draft"}},{"before":"27d1912c39d48419e0abbc03c176be6d1fe13cb3","after":"4d42bce4e4d282cbe11d7526e45830bee04bfc58","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-08T11:57:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Draft\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Draft"}},{"before":"3c9e1acb79b28ad22f9155b069e0efdfc7f3b501","after":"27d1912c39d48419e0abbc03c176be6d1fe13cb3","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-01T15:18:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Draft\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Draft"}},{"before":"8c4816fa94b595d9cb7f304c76f186a13a889e6d","after":"3c9e1acb79b28ad22f9155b069e0efdfc7f3b501","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-01T15:18:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Draft\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Draft"}},{"before":null,"after":"8c4816fa94b595d9cb7f304c76f186a13a889e6d","ref":"refs/heads/deletion_timestamp","pushedAt":"2023-05-01T15:11:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lleshchi","name":"Leah Leshchinsky","path":"/lleshchi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44850593?s=80&v=4"},"commit":{"message":"Draft\n\nSigned-off-by: Leah Leshchinsky <lleshchi@redhat.com>","shortMessageHtmlLink":"Draft"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADaDNTUAA","startCursor":null,"endCursor":null}},"title":"Activity · lleshchi/controller-runtime"}