Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main.go:26-29: Global variables are a code smell... #23

Open
0pdd opened this issue Mar 2, 2019 · 0 comments
Open

main.go:26-29: Global variables are a code smell... #23

0pdd opened this issue Mar 2, 2019 · 0 comments

Comments

@0pdd
Copy link

0pdd commented Mar 2, 2019

The puzzle 9-05e94b28 from #9 has to be resolved:

// @todo #9 Global variables are a code smell (especially those in filterse.go).
// They promote coupling across different components inside the same package.
// Figure out a way to remove these global variables. Whatever command line
// parser we choose should be able to auto-generate usage.

The puzzle was created by @llorllale on 02-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

0pdd referenced this issue Mar 2, 2019
* Filters and repo path are specified via command
  line flags
* Can also specify flags via '.gitlint' file in
  $PWD (command line flags take precedence).
  The format of this file is the same as command
  line flags, where each is on a separate line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant