Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultCommitTest.java:73-75: Checkstyle: enforce use of... #34

Open
0pdd opened this issue Feb 7, 2018 · 1 comment
Open

DefaultCommitTest.java:73-75: Checkstyle: enforce use of... #34

0pdd opened this issue Feb 7, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@0pdd
Copy link

0pdd commented Feb 7, 2018

The puzzle 29-71e94be2 from #29 has to be resolved:

https://github.com/llorllale/gitlog-maven-plugin/blob/996b21a631c76c7ea3c852ee8f979a9ffcc101b8/src/test/java/org/llorllale/mvn/plgn/gitlog/DefaultCommitTest.java#L73-L75

The puzzle was created by George Aristy on 07-Feb-18.

Estimate: 30 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@llorllale
Copy link
Owner

llorllale commented Feb 7, 2018

WriteTag seems broken.

This configuration:

    <module name="WriteTag">
      <property name="tag" value="@since"/>
      <property name="tagFormat" value="[0-9]+\.[0-9]+\.[0-9]+"/>
      <property name="tagSeverity" value="ignore"/>
    </module>

... breaks because of the @todo in the following:

/**
 * Tests for {@link DefaultCommit}.
 *
 * @author George Aristy (george.aristy@gmail.com)
 * @since 0.1.0
 * @checkstyle MultipleStringLiterals (500 lines)
 * @todo #34:30min Missing javadoc tag @since check on methods because the WriteTag
 *  check also blindly enforces the rule on overriden methods (@Override). This behavior
 *  is not acceptable.
 */
public final class DefaultCommitTest {

The error is:

C:\dev\loggit-maven-plugin\src\test\java\org\llorllale\mvn\plgn\loggit\DefaultCommitTest.java:37: Type Javadoc tag @since must match pattern '[0-9]+\.[0-9]+\.[0-9]+'. [WriteTag]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants