Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing break in switch #236

Open
dimitrov-ds opened this issue Jul 26, 2021 · 0 comments
Open

Missing break in switch #236

dimitrov-ds opened this issue Jul 26, 2021 · 0 comments

Comments

@dimitrov-ds
Copy link

Hi,
I've just ran Coverity, version 2020.03, static analysis on Yajl 2.1.0 and it highlighted a potential issue.
In the yajl_parser.c file, at line 404, the case for value "yajl_tok_right_bracket" is not terminated by a 'break' statement.
I can see that there are number of other cases not terminated by a 'break' statement but there are comments for each of them saying that the fall through is intentional. The case I am mentioning in this issue does not have such a comment.
Is the missing 'break' statement is intentional or it is a bug?

Thanks,
Dimitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant