-
Notifications
You must be signed in to change notification settings - Fork 307
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
In LowerToHW we copy the name from FIRRTL ops to the lowered HW ops. We often call `createOrFold` when creating the HW ops, which can mean that there is no operation to copy the name to. We were not properly detecting this scenario, which could cause us to try to copy the name to a null operation. Most ops were already covered under a guard in a generic code path, but div-like and subaccess-like operations needed to be guarded. Some of these problems are impossible to test right now as we require folders to be implemented for some operations. This backports #7358 to 1.62.0 for Chisel 6 users. Co-authored-by: Andrew Young <youngar17@gmail.com>
- Loading branch information
Showing
2 changed files
with
13 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters