From bf313f131b5a099ead5b9a8839c8ac6e383a2640 Mon Sep 17 00:00:00 2001 From: John Demme Date: Thu, 8 Aug 2024 10:52:48 +0000 Subject: [PATCH] feedback --- lib/Dialect/ESI/runtime/cpp/include/esi/Ports.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/Dialect/ESI/runtime/cpp/include/esi/Ports.h b/lib/Dialect/ESI/runtime/cpp/include/esi/Ports.h index 2ba525298f94..c025cbfa085c 100644 --- a/lib/Dialect/ESI/runtime/cpp/include/esi/Ports.h +++ b/lib/Dialect/ESI/runtime/cpp/include/esi/Ports.h @@ -42,14 +42,14 @@ class ChannelPort { virtual void disconnect() = 0; virtual bool isConnected() const = 0; - /// Poll for incoming data. Returns true if data was read into a buffer as a - /// result of the poll. Calling the call back could (will) also happen in that - /// case. Some backends need this to be called periodically. In the usual - /// case, this will be called by a background thread, but the ESI runtime does - /// not want to assume that the host processes use standard threads. If the - /// user wants to provide their own threads, they need to call this on each - /// port occasionally. This is also called from the 'master' poll method in - /// the Accelerator class. + /// Poll for incoming data. Returns true if data was read or written into a + /// buffer as a result of the poll. Calling the call back could (will) also + /// happen in that case. Some backends need this to be called periodically. In + /// the usual case, this will be called by a background thread, but the ESI + /// runtime does not want to assume that the host processes use standard + /// threads. If the user wants to provide their own threads, they need to call + /// this on each port occasionally. This is also called from the 'master' poll + /// method in the Accelerator class. bool poll() { if (isConnected()) return pollImpl();