From fd60368575b36d29858ced39bb4978b44915b203 Mon Sep 17 00:00:00 2001 From: Mike Urbach Date: Thu, 16 Jan 2025 10:41:47 -0800 Subject: [PATCH] [CI/CD] Update upload-artifacts and download-artifcats. The v3 of these actions is deprecated: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/. While GitHub has indicated this will stop working on January 30, we seem to have already hit a failure related to this: https://github.com/llvm/circt/actions/runs/12815228763/job/35733456176?pr=8089#step:1:25. This updates to use the v4 version of these actions where we were on v3, and in the Python wheel building specifically, it makes one small tweak following the migration guide: https://github.blog/news-insights/product-news/get-started-with-v4-of-github-actions-artifacts/#compatibility. --- .github/workflows/buildAndTest.yml | 4 ++-- .github/workflows/unifiedBuildTestAndInstall.yml | 4 ++-- .github/workflows/uploadWheels.yml | 9 +++++---- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/buildAndTest.yml b/.github/workflows/buildAndTest.yml index 194631664bf9..13cbbc182257 100644 --- a/.github/workflows/buildAndTest.yml +++ b/.github/workflows/buildAndTest.yml @@ -97,7 +97,7 @@ jobs: # Upload the format patches to an artifact (zip'd) associated # with the workflow run. Only run this on a failure. - name: Upload format patches - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 continue-on-error: true if: ${{ failure() }} with: @@ -285,7 +285,7 @@ jobs: # Upload the tidy patches to an artifact (zip'd) associated # with the workflow run. Only run this on a failure. - name: Upload tidy patches - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 continue-on-error: true if: ${{ failure() }} with: diff --git a/.github/workflows/unifiedBuildTestAndInstall.yml b/.github/workflows/unifiedBuildTestAndInstall.yml index d55bfcce55e2..359e96d2d8d4 100644 --- a/.github/workflows/unifiedBuildTestAndInstall.yml +++ b/.github/workflows/unifiedBuildTestAndInstall.yml @@ -265,14 +265,14 @@ jobs: # Upload build artifacts - name: Upload Binary (Non-Tag) - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: inputs.install && github.ref_type != 'tag' with: name: ${{ steps.name_archive.outputs.name }} path: ${{ steps.name_archive.outputs.name }} retention-days: 7 - name: Upload SHA256 (Non-Tag) - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: inputs.install && github.ref_type != 'tag' with: name: ${{ steps.name_archive.outputs.name }}.sha256 diff --git a/.github/workflows/uploadWheels.yml b/.github/workflows/uploadWheels.yml index aa86f0a8d8dd..1f5ec7600a58 100644 --- a/.github/workflows/uploadWheels.yml +++ b/.github/workflows/uploadWheels.yml @@ -53,9 +53,9 @@ jobs: SETUPTOOLS_SCM_DEBUG: True - name: Upload (stage) wheels as artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: - name: python-wheels + name: python-wheels-${{ matrix.config.cibw_build }} path: ./wheelhouse/*.whl retention-days: 7 if-no-files-found: error @@ -73,9 +73,10 @@ jobs: steps: - name: Download wheels - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: - name: python-wheels + pattern: python-wheels-* + merge-multiple: true path: ./wheelhouse/ - name: List downloaded wheels