Fix invalid rewriter API usages #6960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7FM
added
bug
7FM
commented
Apr 29, 2024
uenoku
approved these changes
Apr 29, 2024
7FM
force-pushed
the
dev/7FM/op_use_after_free
branch
from
4d99258
to
20519a0
Compare
dtzSiFive
approved these changes
Apr 29, 2024
|
Thanks @7FM , looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to llvm/llvm-project@6008cd4:
I probably did not catch all invalid rewriter API usages since I have only checked
replaceOpWithNewOpusages.In general, one can create similar invalid API usages with
eraseOpandreplaceOp.