Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImportVerilog] Fix unknown name caused by local variables. #6995

Merged
merged 1 commit into from
May 8, 2024

Conversation

hailongSun2000
Copy link
Member

If we don't collect the local temporary variables, it triggers the following error:
For example:

module Temporary();
  int x, y, z;
  always_comb begin
    automatic int a;
    a = x + 1;
    y = a;
    a = a + 1;
    z = a;
  end
endmodule
Temporary.sv:5:5: error: unknown name `a`
    a = x + 1;

@hailongSun2000 hailongSun2000 added the Verilog/SystemVerilog Involving a Verilog dialect label May 7, 2024
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you add a test?

@hailongSun2000
Copy link
Member Author

LGTM! Could you add a test?

No problem! But I'll wait to add it tomorrow. And the IR is the same as non-local variables.

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I agree with @uenoku: once there's a test this is good to go 😃

@hailongSun2000
Copy link
Member Author

Thanks for the fix! I agree with @uenoku: once there's a test this is good to go 😃

I have added the test cases.

@hailongSun2000
Copy link
Member Author

LGTM! Could you add a test?

I have added the test cases.

@hailongSun2000 hailongSun2000 merged commit 06cb84a into llvm:main May 8, 2024
4 checks passed
@hailongSun2000 hailongSun2000 deleted the hailong/fix-unknown-name branch July 4, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Verilog/SystemVerilog Involving a Verilog dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants