Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++23] [Modules] Compile error: different definitions in different modules #80800

Closed
JinHai-CN opened this issue Feb 6, 2024 · 7 comments
Closed
Labels
c++23 clang:modules C++20 modules and Clang Header Modules

Comments

@JinHai-CN
Copy link

JinHai-CN commented Feb 6, 2024

Hi guys, Our project is using c++20 and applied modules feature. But when we compile it with c++23, we get the following error.

1707198156578.png

Is there a problem with the STL I'm wrapping or something else?

Clang: Ubuntu clang version 18.1.0 (++20240203081317+140ad18e1ea2-1exp120240203201335.24)

@EugeneZelenko EugeneZelenko added clang:modules C++20 modules and Clang Header Modules c++23 and removed new issue labels Feb 6, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 6, 2024

@llvm/issue-subscribers-clang-modules

Author: Jin Hai (JinHai-CN)

Hi guys, Our [project](https://github.com/infiniflow/infinity) is using c++20 and applied modules feature. But when we compile it with c++23, we get the following error.

Uploading Screenshot from 2024-02-06 13-21-21.png…

Is there a problem with the STL I'm wrapping or something else?

Clang: Ubuntu clang version 18.1.0 (++20240203081317+140ad18e1ea2-1exp120240203201335.24)

@dwblaikie
Copy link
Collaborator

Can't seem to load the image - and generally a copy/paste of the text is more usable for everyone than a screenshot. If you could include the copy/pasted text, that'd be handy, thanks!

@ChuanqiXu9
Copy link
Member

While I can't see the image either, I guess this is related to #79959 (You can read the document to get the rationale). For verifying, you can either compile a clang from source in trunk or wait for the next RC of clang18 in the next week.

@JinHai-CN
Copy link
Author

Can't seem to load the image - and generally a copy/paste of the text is more usable for everyone than a screenshot. If you could include the copy/pasted text, that'd be handy, thanks!

No problem. At first, I plan to paste the text, which is not readable from my view. So I give the screen shot. OK, I will give the error text.

@JinHai-CN
Copy link
Author

JinHai-CN commented Feb 7, 2024

While I can't see the image either, I guess this is related to #79959 (You can read the document to get the rationale). For verifying, you can either compile a clang from source in trunk or wait for the next RC of clang18 in the next week.

Ok, I will wait for the next clang-18 RC.

@ChuanqiXu9
Copy link
Member

Can't seem to load the image - and generally a copy/paste of the text is more usable for everyone than a screenshot. If you could include the copy/pasted text, that'd be handy, thanks!

No problem. At first, I plan to paste the text, which is not readable from my view. So I give the screen shot. OK, I will give the error text.

It is still images. I'll suggest to copy the text directly next time.

While I can't see the image either, I guess this is related to #79959 (You can read the document to get the rationale). For verifying, you can either compile a clang from source in trunk or wait for the next RC of clang18 in the next week.

Ok, I will wait for the next clang-18 RC.

I just saw the patch is included in the new clang-18 RC: https://github.com/llvm/llvm-project/commits/llvmorg-18.1.0-rc2/

@JinHai-CN
Copy link
Author

Can't seem to load the image - and generally a copy/paste of the text is more usable for everyone than a screenshot. If you could include the copy/pasted text, that'd be handy, thanks!

No problem. At first, I plan to paste the text, which is not readable from my view. So I give the screen shot. OK, I will give the error text.

It is still images. I'll suggest to copy the text directly next time.

While I can't see the image either, I guess this is related to #79959 (You can read the document to get the rationale). For verifying, you can either compile a clang from source in trunk or wait for the next RC of clang18 in the next week.

Ok, I will wait for the next clang-18 RC.

I just saw the patch is included in the new clang-18 RC: https://github.com/llvm/llvm-project/commits/llvmorg-18.1.0-rc2/

Yes, it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++23 clang:modules C++20 modules and Clang Header Modules
Projects
None yet
Development

No branches or pull requests

5 participants