Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge c007fbb19879f9b597b47ae772c53e53cdc65f29 into 18.x #81809

Closed
brad0 opened this issue Feb 15, 2024 · 3 comments
Closed

Merge c007fbb19879f9b597b47ae772c53e53cdc65f29 into 18.x #81809

brad0 opened this issue Feb 15, 2024 · 3 comments

Comments

@brad0
Copy link
Contributor

brad0 commented Feb 15, 2024

[PATCH] MipsAsmParser/O32: Don't add redundant $ to $-prefixed symbol
in the la macro (#80644)

When parsing the la macro, we add a duplicate $ prefix in
getOrCreateSymbol,
leading to error: Undefined temporary symbol $$yy for code like:

xx:
	la	$2,$yy
$yy:
	nop

Remove the duplicate prefix.

In addition, recognize .L-prefixed symbols as local for O32.

See: #65020.

@brad0
Copy link
Contributor Author

brad0 commented Feb 15, 2024

/cherry-pick c007fbb

@llvmbot llvmbot closed this as completed Feb 15, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in LLVM Release Status Feb 15, 2024
@llvmbot
Copy link
Member

llvmbot commented Feb 15, 2024

/pull-request #81810

@llvmbot
Copy link
Member

llvmbot commented Feb 15, 2024

@llvm/issue-subscribers-backend-mips

Author: Brad Smith (brad0)

[PATCH] MipsAsmParser/O32: Don't add redundant $ to $-prefixed symbol in the la macro (#80644)

When parsing the la macro, we add a duplicate $ prefix in
getOrCreateSymbol,
leading to error: Undefined temporary symbol $$yy for code like:

xx:
	la	$2,$yy
$yy:
	nop

Remove the duplicate prefix.

In addition, recognize .L-prefixed symbols as local for O32.

See: #65020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants