Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 110141b37813dc48af33de5e1407231e56acdfc5 into 18.x #84665

Closed
brad0 opened this issue Mar 10, 2024 · 3 comments
Closed

Merge 110141b37813dc48af33de5e1407231e56acdfc5 into 18.x #84665

brad0 opened this issue Mar 10, 2024 · 3 comments

Comments

@brad0
Copy link
Contributor

brad0 commented Mar 10, 2024

[OpenMP] fix endianness dependent definitions in OMP headers
for MSVC (#84540)

MSVC does not define BYTE_ORDER making the check for BigEndian
erroneously evaluate to true and breaking the struct definitions in MSVC
compiled builds correspondingly. The fix adds an additional check for
whether BYTE_ORDER is defined by the compiler to fix these.

@brad0
Copy link
Contributor Author

brad0 commented Mar 10, 2024

/cherry-pick 110141b

@llvmbot
Copy link
Member

llvmbot commented Mar 10, 2024

@llvm/issue-subscribers-openmp

Author: Brad Smith (brad0)

[OpenMP] fix endianness dependent definitions in OMP headers for MSVC (#84540)

MSVC does not define BYTE_ORDER making the check for BigEndian
erroneously evaluate to true and breaking the struct definitions in MSVC
compiled builds correspondingly. The fix adds an additional check for
whether BYTE_ORDER is defined by the compiler to fix these.

@llvmbot llvmbot closed this as completed Mar 10, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in LLVM Release Status Mar 10, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 10, 2024

/pull-request #84668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants