Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport shadowing warnings to a LLVM 18 release #84898

Closed
sheredom opened this issue Mar 12, 2024 · 5 comments
Closed

Backport shadowing warnings to a LLVM 18 release #84898

sheredom opened this issue Mar 12, 2024 · 5 comments
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer release:backport release:cherry-pick-failed
Milestone
LLVM 18.X Release

Comments

@sheredom
Copy link
Contributor

We'd like to request that #74512 is backported to an LLVM 18 release. This issue affects our Unreal Engine customers that want to use latest clang and have shadowing warnings enabled, as there are lots of false warnings that this commit fixed.

/cherry-pick c90114c
@sheredom sheredom added release:backport clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer labels Mar 12, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 12, 2024

We'd like to request that #74512 is backported to an LLVM 18 release. This issue affects our Unreal Engine customers that want to use latest clang and have shadowing warnings enabled, as there are lots of false warnings that this commit fixed.

/cherry-pick c90114c

Error: Command failed due to missing milestone.

@sheredom sheredom added this to the LLVM 18.X Release milestone Mar 12, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Mar 12, 2024
@sheredom
Copy link
Contributor Author

Whoopsie adding the milestone!

@sheredom
Copy link
Contributor Author

/cherry-pick c90114c

@llvmbot
Copy link
Member

llvmbot commented Mar 12, 2024

Failed to cherry-pick: c90114c

https://github.com/llvm/llvm-project/actions/runs/8248650647

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@sheredom
Copy link
Contributor Author

Manually made a pull request here #84912

@sheredom sheredom mentioned this issue Mar 12, 2024
Merged
@nikic nikic closed this as completed Mar 12, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in LLVM Release Status Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer release:backport release:cherry-pick-failed
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 18.X Release
Development

No branches or pull requests
3 participants
@nikic @sheredom @llvmbot