Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 6b70c5d79fe44cbe01b0443454c6952c5b541585 into 18.1.x #86373

Closed
brad0 opened this issue Mar 23, 2024 · 5 comments
Closed

Merge 6b70c5d79fe44cbe01b0443454c6952c5b541585 into 18.1.x #86373

brad0 opened this issue Mar 23, 2024 · 5 comments

Comments

@brad0
Copy link
Contributor

brad0 commented Mar 23, 2024

[PowerPC] provide CFI for ELF32 to unwind cr2, cr3, cr4
(#83098)

Delete the code that skips the CFI for the condition register on ELF32.
The code checked !MustSaveCR, which happened only when
Subtarget.is32BitELFABI(), where spillCalleeSavedRegisters is spilling
cr in a different way. The spill was missing CFI. After deleting this
code, a spill of cr2 to cr4 gets CFI in the same way as a spill of r14
to r31.

Fixes #83094

@brad0 brad0 added this to the LLVM 18.X Release milestone Mar 23, 2024
@brad0
Copy link
Contributor Author

brad0 commented Mar 23, 2024

/cherry-pick 6b70c5d

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 23, 2024

@llvm/issue-subscribers-backend-powerpc

Author: Brad Smith (brad0)

[PowerPC] provide CFI for ELF32 to unwind cr2, cr3, cr4 (#83098)

Delete the code that skips the CFI for the condition register on ELF32.
The code checked !MustSaveCR, which happened only when
Subtarget.is32BitELFABI(), where spillCalleeSavedRegisters is spilling
cr in a different way. The spill was missing CFI. After deleting this
code, a spill of cr2 to cr4 gets CFI in the same way as a spill of r14
to r31.

Fixes #83094

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 23, 2024

Failed to cherry-pick: 6b70c5d

https://github.com/llvm/llvm-project/actions/runs/8399216034

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@brad0
Copy link
Contributor Author

brad0 commented Mar 23, 2024

/cherry-pick 3196005 6b70c5d

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 23, 2024

/pull-request #86375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants