Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 8b859c6e4a8e9ab9969582267bbdc04ed6bfa535 into 18.1.x #88336

Closed
brad0 opened this issue Apr 11, 2024 · 3 comments
Closed

Merge 8b859c6e4a8e9ab9969582267bbdc04ed6bfa535 into 18.1.x #88336

brad0 opened this issue Apr 11, 2024 · 3 comments

Comments

@brad0
Copy link
Contributor

brad0 commented Apr 11, 2024

[MIPS] Fix the opcode of max.fmt and mina.fmt (#85609)

  • The opcode of the mina.fmt and max.fmt is documented wrong, the
    object code compiled from the same assembly with LLVM behaves
    differently than one compiled with GCC and Binutils.

  • Modify the opcodes to match Binutils. The actual opcodes are as
    follows:

    {5,3} | bits {2,0} of func
    | ... | 100 | 101 | 110 | 111
    -----+-----+-----+-----+-----+-----
    010 | ... | min | mina | max | maxa

@brad0
Copy link
Contributor Author

brad0 commented Apr 11, 2024

/cherry-pick 8b859c6

@llvmbot llvmbot closed this as completed Apr 11, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in LLVM Release Status Apr 11, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 11, 2024

/pull-request #88337

@llvmbot
Copy link
Member

llvmbot commented Apr 11, 2024

@llvm/issue-subscribers-backend-mips

Author: Brad Smith (brad0)

[MIPS] Fix the opcode of max.fmt and mina.fmt (#85609)
  • The opcode of the mina.fmt and max.fmt is documented wrong, the
    object code compiled from the same assembly with LLVM behaves
    differently than one compiled with GCC and Binutils.

  • Modify the opcodes to match Binutils. The actual opcodes are as
    follows:

    {5,3} | bits {2,0} of func
    | ... | 100 | 101 | 110 | 111
    -----+-----+-----+-----+-----+-----
    010 | ... | min | mina | max | maxa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants