Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "[Codegen][X86] Fix /HOTPATCH with clang-cl and inline asm" into 18.x #88386

Closed
aganea opened this issue Apr 11, 2024 · 2 comments
Closed

Comments

@aganea
Copy link
Member

aganea commented Apr 11, 2024

Please merge the following patch:

[Codegen][X86] Fix /HOTPATCH with clang-cl and inline asm (#87639)
This fixes an edge case where functions starting with inline assembly
would assert while trying to lower that inline asm instruction.

After this PR, for now we always add a no-op (xchgw in this case) without
considering the size of the next inline asm instruction. We might want
to revisit this in the future.

This fixes Unreal Engine 5.3.2 compilation with clang-cl and /HOTPATCH.

Should close #56234

/cherry-pick ec1af63

@aganea aganea added this to the LLVM 18.X Release milestone Apr 11, 2024
@aganea aganea changed the title Merge ec1af63dde58c735fe60d6f2aafdb10fa93f410d into 18.x Merge "[Codegen][X86] Fix /HOTPATCH with clang-cl and inline asm" into 18.x Apr 11, 2024
@llvmbot llvmbot closed this as completed Apr 11, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 11, 2024

/pull-request #88388

@llvmbot
Copy link
Collaborator

llvmbot commented Apr 11, 2024

@llvm/issue-subscribers-backend-x86

Author: Alexandre Ganea (aganea)

Please merge the following patch:

> [Codegen][X86] Fix /HOTPATCH with clang-cl and inline asm (#87639)
> This fixes an edge case where functions starting with inline assembly
> would assert while trying to lower that inline asm instruction.
>
> After this PR, for now we always add a no-op (xchgw in this case) without
> considering the size of the next inline asm instruction. We might want
> to revisit this in the future.
>
> This fixes Unreal Engine 5.3.2 compilation with clang-cl and /HOTPATCH.
>
> Should close #56234
>

/cherry-pick ec1af63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants