You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Codegen][X86] Fix /HOTPATCH with clang-cl and inline asm (#87639)
This fixes an edge case where functions starting with inline assembly
would assert while trying to lower that inline asm instruction.
After this PR, for now we always add a no-op (xchgw in this case) without
considering the size of the next inline asm instruction. We might want
to revisit this in the future.
This fixes Unreal Engine 5.3.2 compilation with clang-cl and /HOTPATCH.
aganea
changed the title
Merge ec1af63dde58c735fe60d6f2aafdb10fa93f410d into 18.x
Merge "[Codegen][X86] Fix /HOTPATCH with clang-cl and inline asm" into 18.x
Apr 11, 2024
> [Codegen][X86] Fix /HOTPATCH with clang-cl and inline asm (#87639)
> This fixes an edge case where functions starting with inline assembly
> would assert while trying to lower that inline asm instruction.
>
> After this PR, for now we always add a no-op (xchgw in this case) without
> considering the size of the next inline asm instruction. We might want
> to revisit this in the future.
>
> This fixes Unreal Engine 5.3.2 compilation with clang-cl and /HOTPATCH.
>
> Should close #56234
>
Please merge the following patch:
/cherry-pick ec1af63
The text was updated successfully, but these errors were encountered: