Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake][Release] Disable PGO (#88465) #89000

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Commits on Apr 17, 2024

  1. [CMake][Release] Disable PGO (llvm#88465)

    Running the test-release.sh script with PGO enabled causes build errors
    like:
    
    ld.lld: error: Function Import: link error: linking module flags
    'ProfileSummary': IDs have conflicting values
    
    I believe this a build system bug due to the PGO profile data being
    generated unconditionally. If you run `ninja check-all` and then `ninja
    install` like we do in test-release.sh, then the profile data is
    regenerated during `ninja install` and some of the clang tools which are
    not test dependencies get build during the ninja install step with
    different profile data. When these tools link against the LLVM
    libraries, like libSupport, we end up with these errors.
    
    (cherry picked from commit 0d2bb7f)
    tstellar committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    69b66a5 View commit details
    Browse the repository at this point in the history