-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AArch64][compiler-rt] Disable SME ABI routines if function multiversioning is not supported #94973
Merged
kmclaughlin-arm
merged 4 commits into
llvm:main
from
kmclaughlin-arm:sme-abi-disable-fmv
Jun 12, 2024
+17
−6
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f946f33
[AArch64][compiler-rt] Guard sme-abi-vg.c with !defined(DISABLE_AARCH…
kmclaughlin-arm d952a83
- Add a cmake warning for enabling SME without FMV support.
kmclaughlin-arm ed21402
- Extend warnings in builtins/CMakeLists.txt to cover other requirements
kmclaughlin-arm 3734ab0
- Remove !defined(DISABLE_AARCH64_FMV) guard from sme-abi-vg.c
kmclaughlin-arm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you can just choose not to implement these specific routines, but still compile the rest. If the SME ABI routines require this feature, then we better make that dependency clear in cmake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a warning to CMakeLists where we enable the SME ABI routines, though I can change this to an error if that would be more appropriate?