Skip to content

Commit

Permalink
Test(web-twig): Correct usage of boolean with attribute
Browse files Browse the repository at this point in the history
  • Loading branch information
literat committed Mar 30, 2023
1 parent d2910f2 commit c8bc461
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 13 deletions.
4 changes: 2 additions & 2 deletions packages/web-twig/src/Resources/components/Modal/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ footer of the dialog.
</ModalDialog>
<ModalDialog elementType="form" isExpandedOnMobile=false method="dialog">
<ModalDialog elementType="form" isExpandedOnMobile={false} method="dialog">
</ModalDialog>
```
Expand Down Expand Up @@ -104,7 +104,7 @@ to fit the height of its content (if smaller than viewport).
<ModalDialog>
<ModalHeader
closeLabel="Close form"
enableDismiss=false
enableDismiss={false}
modalId="modal-composed"
titleId="modal-composed-title"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
TextArea
</label>
<textarea minlength="6" maxlength="10" id="example" name="example" class="TextArea__input" rows="10" required>
TextArea value
</textarea>
TextArea value </textarea>
<div class="TextArea__message">
validation failed
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
TextArea
</label>
<textarea id="example" name="" class="TextArea__input">

</textarea>
</textarea>
<div class="TextArea__helperText">
This is helper text
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
Textarea
</label>
<textarea minlength="6" id="example" name="example" class="TextArea__input" required>

</textarea>
</textarea>
<div class="TextArea__message">
validation failed
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<Button color="primary" isDisabled=false>Not Disabled button</Button>
<Button color="primary" isDisabled={false}>Not Disabled button</Button>
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<Button color="primary" isDisabled=false>Not Disabled button with boolean false prop value</Button>
<Button color="primary" isDisabled="false">Not Disabled button with string false prop value</Button>
<Button color="primary" isDisabled={false}>Not Disabled button with boolean false prop value</Button>
<Button color="primary" isDisabled="false">Not Disabled button with string false prop value</Button>
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
id="modal-composed-2"
titleId="modal-composed-2-title"
>
<ModalDialog elementType="form" isExpandedOnMobile=false autocomplete="on" method="dialog">
<ModalDialog elementType="form" isExpandedOnMobile={false} autocomplete="on" method="dialog">
<ModalHeader
closeLabel="Close form"
enableDismiss=false
enableDismiss={false}
modalId="modal-composed-2"
titleId="modal-composed-2-title"
>
Expand Down

0 comments on commit c8bc461

Please sign in to comment.