+
{serveDetails.http_options === undefined ? (
Serve not started. Please deploy a serve application first.
) : (
-
@@ -192,9 +199,55 @@ export const ServeApplicationsListPage = () => {
+
+
+
)}
-
+
);
};
+
+type ServeControllerLogsProps = {
+ controller: ServeSystemActor;
+};
+
+const ServeControllerLogs = ({
+ controller: { actor_id, log_file_path },
+}: ServeControllerLogsProps) => {
+ const { data: fetchedActor } = useFetchActor(actor_id);
+
+ if (!fetchedActor || !log_file_path) {
+ return
;
+ }
+
+ const tabs: MultiTabLogViewerTabDetails[] = [
+ {
+ title: "Controller logs",
+ nodeId: fetchedActor.address.rayletId,
+ filename: log_file_path.startsWith("/")
+ ? log_file_path.substring(1)
+ : log_file_path,
+ },
+ {
+ title: "Other logs",
+ contents:
+ "Replica logs contain the application logs emitted by each Serve Replica.\n" +
+ "To view replica logs, please click into a Serve application from " +
+ "the table above to enter the Application details page.\nThen, click " +
+ "into a Serve Replica in the Deployments table.\n\n" +
+ "HTTP Proxy logs contains HTTP access logs for each HTTP Proxy.\n" +
+ "To view HTTP Proxy logs, click into a HTTP Proxy from the Serve System " +
+ "Details page.\nThis page can be accessed via the left tab menu or by " +
+ 'clicking "View system status and configuration" link above.',
+ },
+ ];
+ return
;
+};
diff --git a/dashboard/client/src/pages/serve/ServeDeploymentRow.tsx b/dashboard/client/src/pages/serve/ServeDeploymentRow.tsx
index 9b7892a2dda4..347b822dcdcb 100644
--- a/dashboard/client/src/pages/serve/ServeDeploymentRow.tsx
+++ b/dashboard/client/src/pages/serve/ServeDeploymentRow.tsx
@@ -43,17 +43,19 @@ const useStyles = makeStyles((theme) =>
export type ServeDeployentRowProps = {
deployment: ServeDeployment;
application: ServeApplication;
+ startExpanded?: boolean;
};
export const ServeDeploymentRow = ({
deployment,
application: { last_deployed_time_s },
+ startExpanded = false,
}: ServeDeployentRowProps) => {
const { name, status, message, deployment_config, replicas } = deployment;
const classes = useStyles();
- const [expanded, setExpanded] = useState(false);
+ const [expanded, setExpanded] = useState(startExpanded);
const metricsUrl = useViewServeDeploymentMetricsButtonUrl(name);
return (
diff --git a/dashboard/client/src/pages/serve/ServeLayout.tsx b/dashboard/client/src/pages/serve/ServeLayout.tsx
index 05787efc11ec..f58e61d19a02 100644
--- a/dashboard/client/src/pages/serve/ServeLayout.tsx
+++ b/dashboard/client/src/pages/serve/ServeLayout.tsx
@@ -1,12 +1,13 @@
import { createStyles, makeStyles } from "@material-ui/core";
import React from "react";
+import { RiInformationLine, RiTableLine } from "react-icons/ri";
import { Outlet } from "react-router-dom";
import { MainNavPageInfo } from "../layout/mainNavContext";
+import { SideTabLayout, SideTabRouteLink } from "../layout/SideTabLayout";
const useStyles = makeStyles((theme) =>
createStyles({
root: {
- padding: theme.spacing(3),
width: "100%",
minHeight: 800,
background: "white",
@@ -30,3 +31,21 @@ export const ServeLayout = () => {