Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncertainties fails on python 3.6 #106

Closed
BishopWolf opened this issue Nov 18, 2019 · 8 comments
Closed

uncertainties fails on python 3.6 #106

BishopWolf opened this issue Nov 18, 2019 · 8 comments

Comments

@BishopWolf
Copy link

I have reported this bug here

Basically, the issue is caused by literal python@2 strings not valid for python@3 representation in the uncertainties package, also there are a lot of python@2-isms like iteritems for arrays.

@lebigot
Copy link
Collaborator

lebigot commented Nov 18, 2019

The problem does not lie with the source code of uncertainties but with the installation process.

I am keeping this open, but fixing the problem should start with lmfit/lmfit-py#605.

@BishopWolf
Copy link
Author

You can follow the discussion on Slicer forum here

@BishopWolf
Copy link
Author

I found this read very useful and instructing

@lebigot lebigot closed this as completed Nov 23, 2019
@lebigot
Copy link
Collaborator

lebigot commented Nov 23, 2019

I'm reopening this because the latest version with a wheel is not getting installed properly. I'll work on this later.

@lebigot lebigot reopened this Nov 23, 2019
@BishopWolf
Copy link
Author

BishopWolf commented Nov 26, 2019

The problem with the test build is that you are still using eggs instead of wheels. And when installing from a test docker environment:

Collecting lmfit
  Downloading https://files.pythonhosted.org/packages/59/6e/117794cf85b7345361877e49245870490ae438f1981dea3c6af1316b30e7/lmfit-0.9.14.tar.gz (250kB)
Collecting asteval>=0.9.12
  Downloading https://files.pythonhosted.org/packages/b5/a9/c353f8fde8c7a5eedca5ac4671f8378da2cea71878c1fd11ec89d22c47a8/asteval-0.9.17.tar.gz (53kB)
Requirement already satisfied: numpy>=1.10 in /usr/src/Slicer-build/python-install/lib/python3.6/site-packages (from lmfit) (1.16.2)
Collecting scipy>=0.19
  Downloading https://files.pythonhosted.org/packages/54/18/d7c101d5e93b6c78dc206fcdf7bd04c1f8138a7b1a93578158fa3b132b08/scipy-1.3.3-cp36-cp36m-manylinux1_x86_64.whl (25.2MB)
Requirement already satisfied: six>1.10 in /usr/src/Slicer-build/python-install/lib/python3.6/site-packages (from lmfit) (1.12.0)
Collecting uncertainties>=3.0
  Downloading https://files.pythonhosted.org/packages/2a/c2/babbe5b16141859dd799ed31c03987100a7b6d0ca7c0ed4429c96ce60fdf/uncertainties-3.1.2.tar.gz (232kB)
Building wheels for collected packages: lmfit, asteval, uncertainties
  Building wheel for lmfit (setup.py): started
  Building wheel for lmfit (setup.py): finished with status 'done'
  Created wheel for lmfit: filename=lmfit-0.9.14-cp36-none-any.whl size=88612 sha256=2bef0d19a85e58fd4000043b51df184ce11714c2853bb6dc4430028827901161
  Stored in directory: /root/.cache/pip/wheels/a2/ad/74/1efa3d8294126064517e79592df763b8f30e010c18fadf2d6a
  Building wheel for asteval (setup.py): started
  Building wheel for asteval (setup.py): finished with status 'done'
  Created wheel for asteval: filename=asteval-0.9.17-cp36-none-any.whl size=17744 sha256=a8f6fe9d6ed489b52bb660fa068d272e6b0092ef5ae63b94d1657af74efdec45
  Stored in directory: /root/.cache/pip/wheels/49/74/b2/5b7bcf77e0eed2c654451c84b52d5c7d2fbd95c0e3b36efe0e
  Building wheel for uncertainties (setup.py): started
  Building wheel for uncertainties (setup.py): finished with status 'done'
  Created wheel for uncertainties: filename=uncertainties-3.1.2-cp36-none-any.whl size=96457 sha256=06ebee130afc00c412ec9165be5cecba801498b64968f1f5f28455e21b4f08e5
  Stored in directory: /root/.cache/pip/wheels/d9/d3/0e/5b0b743a8abd50373705427438456da5dc2621891138d7a618
Successfully built lmfit asteval uncertainties
Installing collected packages: 2to3, asteval, scipy, uncertainties, lmfit
Successfully installed 2to3-1.0 asteval-0.9.17 lmfit-0.9.14 scipy-1.3.3 uncertainties-3.1.2

@jcfr
Copy link

jcfr commented Nov 26, 2019

Thanks for moving this forward 🙏

Version 3.1.3 now has a wheel,

In fact, wheels are expected to have the .whl extension

You could look at this project for an example of project releasing wheels. See https://github.com/amueller/word_cloud

@lebigot
Copy link
Collaborator

lebigot commented Dec 3, 2019

The link to 3.1.3 (which I removed) pointed to version 3.1.2, which doesn't have any wheel. I removed the link in the messages above. The current GitHub version does have a wheel (for Python 3 at least). However, it doesn't install properly yet. I'll have another look.

@lebigot
Copy link
Collaborator

lebigot commented Jun 6, 2020

Version 3.1.4 on PyPI has universal wheels.

This would solve this issue (but the original issue was closed because they dropped Python 2 support), so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants