Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security issues #190

Closed
stephen-cox opened this issue May 31, 2023 · 4 comments · Fixed by #273
Closed

Fix security issues #190

stephen-cox opened this issue May 31, 2023 · 4 comments · Fixed by #273

Comments

@stephen-cox
Copy link
Member

stephen-cox commented May 31, 2023

From https://github.com/localgovdrupal/docs/security/dependabot

image

@stephen-cox
Copy link
Member Author

Turns out these are issues with VuePress 1. We'll need to upgrade to version 2, https://github.com/vuepress/vuepress-next

@millnut
Copy link
Member

millnut commented Aug 20, 2024

I've upgraded this locally to v2, there is still a lot of work to do on the theme as vuepress has moved from stylus to sass as well as the vue components we extend no longer exist.

Would be good to know how to get this on a test area so I can test with AlgoliaSearch as that has had quite an extensive re-write

image
image

@stephen-cox
Copy link
Member Author

If you create a PR then the changes should be automatically get deployed to a test URL in Netlify.

@millnut
Copy link
Member

millnut commented Aug 23, 2024

Excellent thanks @stephen-cox I'm just tweaking the theme to match the new website design. Will create a PR once that is all complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants