Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling issues in editor #700

Open
willguv opened this issue May 8, 2024 · 5 comments
Open

Fix scrolling issues in editor #700

willguv opened this issue May 8, 2024 · 5 comments
Labels

Comments

@willguv
Copy link
Member

willguv commented May 8, 2024

Mentioned at LocalGov Drupal Camp by @benhillsjones (?) and others, there are occasional issues when scrolling up and down pages

Let's walk through this and discuss possible improvements

@aaronhirtenstein
Copy link
Member

We have this issue on localgovdrupal.org and asked @stephen-cox to take a look. He deployed a fix which seems to be working so maybe a quick win?
It's very annoying for content editors as it makes editing pages with long paragraphs very difficult - the work around is zooming out to 33% to enable you to see and hit the save button.

@stephen-cox
Copy link
Member

There's an issue on drupal.org for this here: https://www.drupal.org/project/layout_paragraphs/issues/3417765

The fix I implemented is here: localgovdrupal/localgovdrupal.org@c066006

I didn't upload the patch to Github as it needs discussion as it takes a very different approach to the other patches on the site.

If this of use to others I can discuss with the best way to fix with with the technical people here.

@aaronhirtenstein
Copy link
Member

Cheers @stephen-cox and @justinepocock metioned the modal settings: https://www.blackburn.gov.uk/admin/config/content/layout_paragraphs/modal-settings
You want the settings on that page to look like this
image

@aaronhirtenstein
Copy link
Member

see this Slack thread for video example of the issue: https://localgovdrupal.slack.com/archives/C020SJRQX2M/p1715257361142789

@stephen-cox
Copy link
Member

The setting @justinepocock mentions looks to fix the issue with the action buttons disappearing off the bottom of the screen in a modal popup. Interestingly, this seems to be set with new installs. I don't think we changed this so something changed in Layout Paragraphs to set this by default.

The issue in the video is a different issue and already reported here #664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants