Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded field description on link field #107

Open
tanc opened this issue Jan 15, 2021 · 3 comments
Open

Hard coded field description on link field #107

tanc opened this issue Jan 15, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@tanc
Copy link
Contributor

tanc commented Jan 15, 2021

At the moment the field description for the optional title on the link field is hard-coded to say "If you don't write anything here, we will use: More information"

It would be better if this was managed in config so it can be overwritten on a per site basis. That way this field can be adapted to suit the needs of the site. For instance on Lambeth the title field needs to be required due to the front-end complexity of Drupal outputting a GeneratedLink rather than a standard render array depending on whether you fill in the title or not.

@tanc
Copy link
Contributor Author

tanc commented Jan 15, 2021

@andybroomfield andybroomfield added enhancement New feature or request good first issue Good for newcomers labels Jan 19, 2021
@andybroomfield
Copy link
Contributor

As long as we keep it as the default, it should be fine.
The link field is provided by config, so simply needs to be added there and the form alter hook can be removed.
May also need to remove the generated text in the templates.
If someone wants to make a Pull Request will review.

@andybroomfield andybroomfield added this to the v1.1 milestone May 10, 2021
@andybroomfield andybroomfield modified the milestones: v1.1, v1.8 Nov 24, 2023
@andybroomfield andybroomfield modified the milestones: v1.8, v1.9 Jun 17, 2024
@andybroomfield andybroomfield changed the title Hard coded field description Hard coded field description on link field Jul 3, 2024
@andybroomfield
Copy link
Contributor

The description is coded to the link title part of the widget, which isn't something that can currently be set in Drupal UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants