require-dev and --no-dev

[finnlewis]

Discussing in Merge Monday.

See #295

For full tests to run we need group module which is now require-dev in localgov_alert_banner

So for now the tests are failing on localgov_project localgovdrupal/localgov_project#131

So we need to include group module when running all the tests across the project.

Options:

1. Amend our test.yml to install the dependencies (possibly with composer install localgovdrupal/localgov_alert_banner)
2. Add requirements to the root composer.json in the project

[finnlewis]

Discussing in Tech Governance Meeting.

@ekes suggests that there is a third way.

We can test the localgov_alert_banner tests to skip if the dependency (group) is missing.

So we would want to amend the tests here:

https://github.com/localgovdrupal/localgov_alert_banner/blob/1.x/modules/group_alert_banner/tests/src/Kernel/GroupAlertBannerTest.php

@ekes will tell us how to do this!

[finnlewis]

Like this:

https://git.drupalcode.org/project/search_api/-/blob/8.x-1.x/modules/search_api_db/tests/src/Kernel/AutocompleteTest.php?ref_type=heads#L14

[finnlewis]

@andybroomfield I'm just trying this on a branch and will send you a pull request.

[millnut]

Like this:

https://git.drupalcode.org/project/search_api/-/blob/8.x-1.x/modules/search_api_db/tests/src/Kernel/AutocompleteTest.php?ref_type=heads#L14

I think that is a really good approach to skip the test if the dependency is not present