-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a local task tab for "Alert Banners" for group module #312
Comments
@Adnan-cds as your more familliar with this, would you be able to look? |
Hi @Adnan-cds Just wondering if you happen to have any time to take a look at this issue? |
Sorry, Mark. I was off for nearly two weeks. I will try to look into it this week. |
Oh super. Thanks very much Adnan. Hope you had a nice time away. |
I'm still missing those tabs @Adnan-cds and also I get a 404 at group/1/alert-banners |
Could you please check what version of the localgov_alert_banner module this site is on? |
It's 1.7.4. And it's a fresh install of the module. |
Thanks for confirming. Sorry, I should have asked this before. Is this site on localgov_microsites:3.x or localgov_microsites:4.x? |
I think it's microsites 2. It's still on Drupal 9, so maybe that's the issue. |
Okay, do me a favour and try on localgov_microsites:3.x and see if it works. Finn has discovered an issue with localgov_microsites:4.x and I have raised a fix which is pending review. So localgov_microsites:3.x is the safest bet right now. We can look into a work-around for localgov_microsites:2.x if the site you are working on cannot be upgraded immediately. But first try on a fresh site which is on localgov_microsites:3.x. |
Thanks for looking at this @Adnan-cds much appreciated! |
Hi @Adnan-cds Thanks very much. Sorry it's taken me a bit of time to get back to testing this, I was off all last month. Testing this on Microsites V3 is working fine. So once the microsites I was working on that was on V2 is upgraded, it should be fine as well. === |
At the moment, if you want to create an alert banner you need to go to
yoursite.com/group/{group_id}/alert-banner/create
but there is no way to know that is where you need to go unless you read through the code and find the route definition for this.Can we add a new tab for 'Alert banners' in
group_alert_banner
module toThe text was updated successfully, but these errors were encountered: