Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme refactor: Alert Banner #62

Closed
markconroy opened this issue Jun 22, 2021 · 3 comments
Closed

Theme refactor: Alert Banner #62

markconroy opened this issue Jun 22, 2021 · 3 comments

Comments

@markconroy
Copy link
Member

Sample: http://localgov.dev.mark.ie/

[] Put the templates in place in the theme
[] Move styling into localgov_base theme
[] confirm feature parity

@markconroy markconroy added the 3 label Jun 22, 2021
@andybroomfield
Copy link
Contributor

Are we fully moving the templates and CSS out of alert banner into the theme?
We need templates in the alert banner module as its a custom entity.
I thought we also where planning on keeping basic CSS for the alert banner so it works out the box?

@markconroy
Copy link
Member Author

Hi @andybroomfield

I'm just moving things to the theme for now, so we can see how it works. We can then start backporting them to modules. The alert banner is a good example of where things should remain in the module.

@markconroy
Copy link
Member Author

Hi @andybroomfield

I don't see any changes needed in the Alert Banner for the new theme, except to change this class name (which won't affect anything) - localgovdrupal/localgov_alert_banner#157

I'll close this issue and leave that PR to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants