-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme refactor: Alert Banner #62
Comments
Are we fully moving the templates and CSS out of alert banner into the theme? |
I'm just moving things to the theme for now, so we can see how it works. We can then start backporting them to modules. The alert banner is a good example of where things should remain in the module. |
I don't see any changes needed in the Alert Banner for the new theme, except to change this class name (which won't affect anything) - localgovdrupal/localgov_alert_banner#157 I'll close this issue and leave that PR to you. |
Sample: http://localgov.dev.mark.ie/
[] Put the templates in place in the theme
[] Move styling into localgov_base theme
[] confirm feature parity
The text was updated successfully, but these errors were encountered: