Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error tracing + backtrace #41

Closed
jondot opened this issue Nov 29, 2023 · 4 comments
Closed

error tracing + backtrace #41

jondot opened this issue Nov 29, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@jondot
Copy link
Contributor

jondot commented Nov 29, 2023

when an error occurs and we're doing the handling bit in controller,
we need to manually capture backtrace (only in development), and add it to the trace.

@jondot jondot added enhancement New feature or request STG-4 labels Nov 29, 2023
@jondot jondot added this to the 0.1.7 milestone Dec 12, 2023
@jondot
Copy link
Contributor Author

jondot commented Dec 13, 2023

some of the research:

  1. we convert a result into a response, handling errors in src/controllers/mod.rs. in there we manually report a warn trace
  2. there are some recommendations that if you want to see errors from a handler, you need to instrument(err) it
  3. there's a possibility that error reporting needs to be done via the logging middleware by adding .on_failure

we need to survey various other services/products and see how they report errors that may occur in handlers to the operators (this deals only with the developer and not user of the service)

@jondot
Copy link
Contributor Author

jondot commented Dec 14, 2023

@jondot
Copy link
Contributor Author

jondot commented Dec 17, 2023

done

@jondot jondot closed this as completed Dec 17, 2023
@jondot
Copy link
Contributor Author

jondot commented Dec 18, 2023

for reference, this is how it looks like now:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant