Remove "Loadgen" from CPU warning log messages #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
+ Coverage 81.13% 81.26% +0.12%
==========================================
Files 27 27
Lines 2386 2386
Branches 366 366
==========================================
+ Hits 1936 1939 +3
+ Misses 356 353 -3
Partials 94 94
Continue to review full report at Codecov.
|
|
I was trying to be specific to worker/standalone but as it is actuallt checked on all Runners (even masters), that is not necessary. Lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what
Loadgenmeans but AFAIK it's not a term used either in Locust or in the broader load testing field. I think it makes more sense without it? When I first saw this message I thought it was the name of a class or something 😅