Adding more debug logging for runners.py #1570
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
- Coverage 82.20% 81.72% -0.49%
==========================================
Files 28 28
Lines 2574 2583 +9
Branches 393 393
==========================================
- Hits 2116 2111 -5
- Misses 365 374 +9
- Partials 93 98 +5
Continue to review full report at Codecov.
|
|
lgtm. |
|
|
||
| def stop(self): | ||
| if self.state not in [STATE_INIT, STATE_STOPPED, STATE_STOPPING]: | ||
| self.state = STATE_STOPPING | ||
| logger.debug("Stopping...") |
There was a problem hiding this comment.
oh, but I think this line is no longer needed. you can remove it as part of the actual fix later on :)
There was a problem hiding this comment.
Why is it not needed?
There was a problem hiding this comment.
Because we’re also going to be logging ”Updating state to STATE_STOPPING, old state was X” right after that.
(I was thinking you wrote that line before you implemented update_state, but maybe I was mistaken)
It's almost impossible to investigate issues like #1535 and some of my previous issues without making custom local changes to add more logging, which is annoying and time consuming.
So here I'm adding some more debug log messages and add a function for updating the
state, with a debug log message.