Release docker image for arm64. #1889
Conversation
|
Great to get a arm64 build, just two things:
|
|
Also, in order to release on arm64 I think we need to run at least some basic tests on that platform as well. |
|
@odidev ? |
.github/workflows/tests.yml
Outdated
| - name: build and publish image | ||
| id: docker_build | ||
| uses: docker/build-push-action@v2 | ||
| if: ${{ github.ref == 'refs/heads/master' && github.repository_owner == 'locustio' }} |
There was a problem hiding this comment.
The reason for having this if statement for the push-setting rather than the whole step is that we can see any errors before merging. Is it necessary to move it?
Signed-off-by: odidev <odidev@puresoftware.com>
|
@cyberw , I have added changes as per your suggestions and pushed the commit and am now checking into adding tests for arm64. |
|
@odidev Did you find a way to run the tests on arm? I can merge this without the tests, but it would be nice to have them... |
I have tried to run the test cases on arm64 but the test cases are failing for arm64. Commit link: odidev@eb24c0f GitHub action link: https://github.com/odidev/locust/runs/3814915067?check_suite_focus=true Could you suggest some pointers on these issues and how can I get details of failed cases? |
|
Not sure what is causing that error.. maybe wrong flask version somehow? I guess there is still no proper support for arm on GH so you cant just add it to the matrix build? |
|
I want to try adding 3.10 support, so merging this first makes sense, even without tests... |
The following file has been modified:
Modified .github/workflows/tests.yml file to build and push the image for both amd64 and arm64 platforms.
Signed-off-by: odidev odidev@puresoftware.com